Allon Mureinik has posted comments on this change.
Change subject: webadmin, core: enable edit Posix storage domains
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
probable failure in the error msg translation - please take a look
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 58: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_INVALID);
Line 59: }
Line 60:
Line 61: if (newConnectionDetails.getstorage_type() ==
StorageType.POSIXFS && (newConnectionDetails.getVfsType() == null ||
newConnectionDetails.getVfsType().isEmpty())) {
Line 62: return
failCanDoAction(VdcBllMessages.VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE);
Don't we already have such a validation when creating the connection (i.e., an
error msg we can recycle?)
Line 63: }
Line 64:
Line 65: Guid vdsmId = getParameters().getVdsId();
Line 66: if (vdsmId == null || vdsmId.equals(Guid.Empty)) {
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommandTest.java
Line 45:
Line 46: private StorageServerConnections newNFSConnection = null;
Line 47: private StorageServerConnections newPosixConnection = null;
Line 48: private StorageServerConnections oldNFSConnection = null;
Line 49: private StorageServerConnections oldPosixConnection = null;
In a single test you either test POSIX flow or NFS flow - why keep two sets of
memeers?
Line 50:
Line 51: @Mock
Line 52: private StorageServerConnectionDAO storageConnDao;
Line 53:
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 577: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty.
Line 578: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can
contain only 'A-Z', 'a-z', '0-9', '_' characters
Line 579: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related
operations can't be performed while the Storage Pool Manager is down.\nPlease
make sure the Storage Pool Manager is up and running, and check network
connectivity.
Line 580: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 581: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE = VFS type cannot be
empty.
AFAIK, spaces are not allowed around the "=" here.
Line 582: VALIDATION.TAGS.INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 583: VALIDATION.VM_POOLS.NAME.NOT_NULL=Pool name is required
Line 584: VALIDATION.ROLES.NAME.NOT_NULL=Role name is required
Line 585: VALIDATION.ROLES.ID.NOT_NULL=Role ID is required
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 575: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty.
Line 576: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can
contain only 'A-Z', 'a-z', '0-9', '_' characters
Line 577: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related
operations can't be performed while the Storage Pool Manager is down.\nPlease
make sure the Storage Pool Manager is up and running, and check network
connectivity.
Line 578: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 579: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE = VFS type cannot be
empty.
here too
Line 580: VALIDATION_TAGS_INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 581: VALIDATION_VM_POOLS_NAME_NOT_NULL=Pool name is required
Line 582: VALIDATION_ROLES_NAME_NOT_NULL=Role name is required
Line 583: VALIDATION_ROLES_ID_NOT_NULL=Role ID is required
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 572: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty.
Line 573: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can
contain only 'A-Z', 'a-z', '0-9', '_' characters
Line 574: STORAGE_OPERATION_FAILED_SPM_NETWORK_PROBLEMS=Storage related
operations can't be performed while the Storage Pool Manager is down.\nPlease
make sure the Storage Pool Manager is up and running, and check network
connectivity.
Line 575: VALIDATION_STORAGE_CONNECTION_INVALID=Mount path is illegal, please
use [IP:/path or FQDN:/path] convention.
Line 576: VALIDATION_STORAGE_CONNECTION_EMPTY_VFSTYPE = VFS type cannot be
empty.
here too
Line 577: VALIDATION_TAGS_INVALID_TAG_NAME=Invalid tag name. Only alphanumeric
chars, '-' and '_' characters are valid
Line 578: VALIDATION_VM_POOLS_NAME_NOT_NULL=Pool name is required
Line 579: VALIDATION_ROLES_NAME_NOT_NULL=Role name is required
Line 580: VALIDATION_ROLES_ID_NOT_NULL=Role ID is required
--
To view, visit http://gerrit.ovirt.org/13640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8904ffab80e9d6e6bfdee4b8375872d1ff64b4d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
