Tal Nisan has posted comments on this change.
Change subject: core: Unfilter ImagesHandler.PerformImagesChecks
......................................................................
Patch Set 10: Verified; Looks good to me, approved
(1 inline comment)
Minor comment, up to you if you decide to accept, other than that +2
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 223: true,
Line 224: false,
Line 225: false,
Line 226: true,
Line 227: ImagesHandler.filterImageDisks(diskList, true,
false))) {
It's one disk and you're only checking for shareable, why all the overhead? if
it's getDisk().isSharable() just send an empty list, the ternary operator you
like so much can come in handy here ;)
Line 228: return false;
Line 229: }
Line 230: }
Line 231:
--
To view, visit http://gerrit.ovirt.org/12321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc93d1bb72daed053f0f37ae3c3f12efef915669
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
