Allon Mureinik has posted comments on this change. Change subject: webadmin: Display correct error when adding new storage ......................................................................
Patch Set 2: Looks good to me, approved (2 inline comments) Minor inline issues, please address when you rebase. .................................................... Commit Message Line 5: CommitDate: 2013-04-07 17:04:59 +0300 Line 6: Line 7: webadmin: Display correct error when adding new storage Line 8: Line 9: When adding a new Storage Domain (of NFS/Local type) the error displayed Doesn't this happen for /any/ file domain (i.e., including POSIX and Gluster)? Line 10: when the connection was failed was always "Error creating a storage domain" Line 11: instead of the actual error from VDSM (no permission error etc.), the connect Line 12: command was changed to propegated the VDSM error to the client there it will Line 13: be tranlsated and be displayed as the translated user friendly value .................................................... File frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties Line 225: VdcActionType___MoveVm=Move VM image to a different Storage Domain Line 226: VdcActionType___AddVmAndAttachToUser=Add VM and Attach to User Line 227: VdcActionType___AttachUserToVmFromPool=Attach User to a specific VM from VM Pool Line 228: VdcActionType___AttachUserToVmFromPoolAndRun=Run VM from VM Pool (User Portal) Line 229: VdcActionType___AddStorageServerConnection=Add Storage Connection s/Storage/Storage Server/ Line 230: VdcActionType___DataCenters=Data Centers Line 231: VdcActionType___Clusters=Clusters Line 232: VdcActionType___Hosts=Hosts Line 233: VdcActionType___Storage=Storage -- To view, visit http://gerrit.ovirt.org/13681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f721d3f10596253ca194a36139ba9ebcdff246 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
