Allon Mureinik has posted comments on this change.
Change subject: engine: VmTemplate cleanup (1/2)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
Line 54:
Line 55: private boolean disabled;
Line 56:
Line 57: public VmTemplate(int childCount, Date creationDate, String
description, int memSizeMb, String name,
Line 58: int numOfSockets, int cpuPerSocket, VmOsType os, Guid
vdsGroupId, Guid vmtGuid, String domain,
consider numSockets instead of numOfSockets.
consider vmTemplateId instead of vmtGuid
Line 59: int numOfMonitors, int status, int usbPolicy, String
timeZone, boolean autoSuspend, int niceLevel,
Line 60: boolean failBack, BootSequence defaultBootSequence, VmType
vmType,
Line 61: boolean smartcardEnabled, boolean deleteProtected, Boolean
tunnelMigration, String vncKeyboardLayout,
Line 62: int minAllocatedMem) {
Line 55: private boolean disabled;
Line 56:
Line 57: public VmTemplate(int childCount, Date creationDate, String
description, int memSizeMb, String name,
Line 58: int numOfSockets, int cpuPerSocket, VmOsType os, Guid
vdsGroupId, Guid vmtGuid, String domain,
Line 59: int numOfMonitors, int status, int usbPolicy, String
timeZone, boolean autoSuspend, int niceLevel,
consider numMonitors instead of numOfMonitors].
Line 60: boolean failBack, BootSequence defaultBootSequence, VmType
vmType,
Line 61: boolean smartcardEnabled, boolean deleteProtected, Boolean
tunnelMigration, String vncKeyboardLayout,
Line 62: int minAllocatedMem) {
Line 63: super(vmtGuid,
--
To view, visit http://gerrit.ovirt.org/13432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie40a67a3172fe6c812ee8fc0b8c0e170fb7b8e59
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
