Moti Asayag has posted comments on this change.
Change subject: core: Added Provider class
......................................................................
Patch Set 15: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Provider.java
Line 1: package org.ovirt.engine.core.common.businessentities;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Would you mind providing a description of this class.
Line 5: public class Provider extends IVdcQueryable implements
BusinessEntity<Guid> {
Line 6:
Line 7: private static final long serialVersionUID = 8279455368568715758L;
Line 8:
Line 10:
Line 11: private String name;
Line 12:
Line 13: private String description;
Line 14:
Is URL by itself sufficient to authenticate the engine as a user on any
provider?
If so, this assumption should be documented - and perhaps a password if
provided as part of the URL should be encrypted.
Line 15: private String url;
Line 16:
Line 17: public String getName() {
Line 18: return name;
Line 69: if (this == obj)
Line 70: return true;
Line 71: if (obj == null)
Line 72: return false;
Line 73: if (getClass() != obj.getClass())
someone used to tell me it preferred to use 'instanceof' rather of class
comparison, especially in a candidate to inheritance/proxy/etc...
Line 74: return false;
Line 75: Provider other = (Provider) obj;
Line 76: if (getId() == null) {
Line 77: if (other.getId() != null)
Line 98:
Line 99: @Override
Line 100: public String toString() {
Line 101: StringBuilder builder = new StringBuilder();
Line 102: builder.append("NetworkProvider [name=")
The 'Network' should be omitted from this context since this is not a specific
provider.
Line 103: .append(getName())
Line 104: .append(", description=")
Line 105: .append(getDescription())
Line 106: .append(", url=")
--
To view, visit http://gerrit.ovirt.org/10783
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67e42286f513cf47dd057a6078ea365d6dff24e9
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
