Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Improved sorting in Setup Networks sub menu
......................................................................

webadmin: Improved sorting in Setup Networks sub menu

Items are now sorted "lexoNumerically" rather than lexicographically.

Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783
Signed-off-by: Lior Vernia <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/13774/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
index 37a098c..d9513a8 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
@@ -4,6 +4,7 @@
 import java.util.Comparator;
 import java.util.List;
 
+import org.ovirt.engine.core.common.utils.LexoNumericComparator;
 import org.ovirt.engine.ui.common.widget.MenuBar;
 import org.ovirt.engine.ui.common.widget.PopupPanel;
 import org.ovirt.engine.ui.uicommonweb.models.hosts.network.NetworkCommand;
@@ -171,9 +172,11 @@
                 });
             } else {
                 Collections.sort(commands, new Comparator<NetworkCommand>() {
+                    private LexoNumericComparator lexoNumeric = new 
LexoNumericComparator();
+
                     @Override
-                    public int compare(NetworkCommand o1, NetworkCommand o2) {
-                        return o1.getName().compareTo(o2.getName());
+                    public int compare(NetworkCommand com1, NetworkCommand 
com2) {
+                        return lexoNumeric.compare(com1.getName(), 
com2.getName());
                     }
                 });
                 MenuBar subMenu = subMenu();


--
To view, visit http://gerrit.ovirt.org/13774
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0de36b3e964801788dc5ccb364c470833f6ea783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to