Alon Bar-Lev has posted comments on this change. Change subject: tools: Support for POSIX and GNU long params in engine-manage-domains ......................................................................
Patch Set 1: Hi, It looks like over complex... using a framework and still needs all this helper code. It is something that I would do very simply in getopt_long... without so much code[1][2]. Parsing parameters should be much simpler... over abstraction makes it very complex. So not always abstracting something is wise decision. Just my thoughts... Alon [1] https://github.com/alonbl/linux-course/blob/master/c/01-stdio-copy/main.c#L58 [2] https://github.com/alonbl/linux-course/blob/master/c/util/getoptutil.c -- To view, visit http://gerrit.ovirt.org/13776 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c70ace879ad17121c2ed11fce0ffc06612b79fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
