Gilad Chaplik has posted comments on this change.
Change subject: webadmin: [WIP] Disable Gluster hooks
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGlusterHookListModel.java
Line 88:
model.setMessage(ConstantsManager.getInstance().getConstants().disableGlusterHooksMessage());
Line 89:
Line 90: if (getSelectedItems() == null) {
Line 91: return;
Line 92: }
duplicate line (80)
Line 93:
Line 94: ArrayList<String> list = new ArrayList<String>();
Line 95: for (Object item : getSelectedItems()) {
Line 96: GlusterHookEntity hook = (GlusterHookEntity) item;
Line 149: super.SelectedItemsChanged();
Line 150: updateActionAvailability();
Line 151: }
Line 152:
Line 153: private void updateActionAvailability() {
it looks like there are too many calls to 'setIsExecutionAllowed(' in this
method, what do you say?
Line 154: if (getSelectedItems() == null || getSelectedItems().size()
== 0) {
Line 155: getEnableHookCommand().setIsExecutionAllowed(false);
Line 156: getDisableHookCommand().setIsExecutionAllowed(false);
Line 157: return;
--
To view, visit http://gerrit.ovirt.org/13574
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I18d86bf20931482b6389c542a037967a70b622c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
