Shireesh Anjal has posted comments on this change.
Change subject: gluster: added cluster level check
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 131: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.0');
Line 132: select fn_db_add_config_value('GlusterRefreshHeavyWeight', 'false',
'3.1');
Line 133: select fn_db_add_config_value('GlusterRefreshRateLight', '5',
'general');
Line 134: select fn_db_add_config_value('GlusterRefreshRateHeavy', '300',
'general');
Line 135: select fn_db_add_config_value('GlusterSupport', 'false', '3.0');
While I still maintain that "supported from version" is a better approach, I'm
open to fixing the problem that is forcing people to add explicit entries for
every version today.
I've sent a patch (http://gerrit.ovirt.org/13787) adding a test case related to
this. If there are any other issues that you're aware of, please let me know
and I'll try to fix them.
Assuming that we reach a stage where there are no "known" issues with the
config framework, I would expect that this patch-set (#5) will become
acceptable to you folks.
Line 136: select
fn_db_add_config_value('GlusterVolumeOptionGroupVirtValue','virt','general');
Line 137: select
fn_db_add_config_value('GlusterVolumeOptionOwnerUserVirtValue','36','general');
Line 138: select
fn_db_add_config_value('GlusterVolumeOptionOwnerGroupVirtValue','36','general');
Line 139:
--
To view, visit http://gerrit.ovirt.org/12970
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3944e8b1d8d82eb19643b99f606da2364d6b582
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
