Daniel Erez has posted comments on this change. Change subject: webadmin: fixing edit policy button style ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) Not sure about the design concerns but the code looks good to me. .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterPolicyView.ui.xml Line 9 Line 10 Line 11 Line 12 Line 13 You can try using our generic action buttons for tabs (i.e. use 'ActionPanel -> createNewActionButton' instead of creating the button manually). -- To view, visit http://gerrit.ovirt.org/13194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfe84279c19fb9b8824acc8fb3d082c131f5083c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
