Juan Hernandez has posted comments on this change.
Change subject: packaging: fixing fqdn validation
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine_validators.py
Line 385: reResolvedAddress = ""
Line 386: if len(addressSet) > 0:
Line 387: reResolvedAddress = addressSet.pop()
Line 388: if reResolvedAddress.lower() == param.lower():
Line 389: counter += 1
Wouldn't make more sense to skip this comparison if the set is empty?
Line 390: else:
Line 391: logging.warn("%s did not reverse-resolve into
%s"%(address,param))
Line 392: if counter < 1:
Line 393: logging.error("The following addresses: %s did not
reverse resolve into %s"%(prettyString, param))
--
To view, visit http://gerrit.ovirt.org/13835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bf1385fbb1770c990c4b31c59d829ce91e4ed00
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Mark Huth <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
