Federico Simoncelli has uploaded a new change for review. Change subject: core: add the paramSource keys to the name parameters ......................................................................
core: add the paramSource keys to the name parameters As createCallForRead also createCallForModification should add the paramSource keys to the name parameters. Change-Id: I5df6d12655ca46b248f85850081f6f8571302125 Signed-off-by: Federico Simoncelli <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/13865/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java index 2e8bb61..f22ec7a 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/SimpleJdbcCallsHandler.java @@ -34,12 +34,12 @@ } public Map<String, Object> executeModification(final String procedureName, final MapSqlParameterSource paramSource) { - return executeImpl(procedureName, paramSource, createCallForModification(procedureName)); + return executeImpl(procedureName, paramSource, createCallForModification(procedureName, paramSource)); } public int executeModificationReturnResult(final String procedureName, final MapSqlParameterSource paramSource) { Integer procedureResult = null; - Map<String, Object> result = executeImpl(procedureName, paramSource, createCallForModification(procedureName)); + Map<String, Object> result = executeImpl(procedureName, paramSource, createCallForModification(procedureName, paramSource)); if (!result.isEmpty()) { List<?> resultArray = (List<?>) result.values().iterator().next(); if (resultArray != null && !resultArray.isEmpty()) { @@ -95,11 +95,14 @@ }; } - private CallCreator createCallForModification(final String procedureName) { + private CallCreator createCallForModification(final String procedureName, final MapSqlParameterSource parameterSource) { return new CallCreator() { @Override public SimpleJdbcCall createCall() { - return new SimpleJdbcCall(template).withProcedureName(procedureName); + SimpleJdbcCall call = new SimpleJdbcCall(template).withProcedureName(procedureName); + call.getInParameterNames().addAll( + SqlParameterSourceUtils.extractCaseInsensitiveParameterNames(parameterSource).keySet()); + return call; } }; } -- To view, visit http://gerrit.ovirt.org/13865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5df6d12655ca46b248f85850081f6f8571302125 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
