Liron Ar has posted comments on this change.
Change subject: core: use local TX in AddVm flow
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 178: new
GetImageInfoVDSCommandParameters(storagePoolId, storageDomainId, imageGroupId,
Line 179:
getImage().getImageId())).getReturnValue();
Line 180:
Line 181: if (image.getImageStatus() != ImageStatus.OK) {
Line 182: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
i haven't looked at the whole patch, but for safety it'll be better to execute
here in required rather then always new, it'll prevent the possible db deadlock
omer referred to.
Line 183: @Override
Line 184: public Void runInTransaction() {
Line 185:
getCompensationContext().snapshotEntityStatus(diskImage,
diskImage.getImageStatus());
Line 186:
diskImage.setImageStatus(image.getImageStatus());
--
To view, visit http://gerrit.ovirt.org/13805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If93240cca8bee4988f28c3de574b44c9db31e8f9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
