Daniel Erez has posted comments on this change.
Change subject: webadmin: unlocalized properties in VM General tab
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
Line 734: }
Line 735:
Line 736: // TODO: Find a better place for this code. It must be something
common,
Line 737: // allowing using of converters' code available in UICommon.
Line 738: public String PriorityToString(int value)
Please fix TemplateGeneralModel -> PriorityToString as well
(preferably, extract to a common method)
Line 739: {
Line 740: int highPriority = AsyncDataProvider.GetMaxVmPriority();
Line 741: int roundedPriority = AsyncDataProvider.RoundPriority(value);
Line 742:
--
To view, visit http://gerrit.ovirt.org/13884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
