Tal Nisan has posted comments on this change.
Change subject: webadmin: Japanese - truncated text in snapshots sub-tab
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
Check out the comment, other than that +2
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
Line 642: @DefaultStringValue("Type")
Line 643: String typeDisk();
Line 644:
Line 645: @DefaultStringValue("Allocation Policy")
Line 646: String allocationDisk();
Do we still need the old constant? If it's not used best to remove it
Line 647:
Line 648: @DefaultStringValue("Allocation")
Line 649: String allocationDiskShort();
Line 650:
--
To view, visit http://gerrit.ovirt.org/13888
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02f7afb0b7521886df2cf0d99fa9d2b19e077d31
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
