Yair Zaslavsky has posted comments on this change. Change subject: engine: Fixing update of host status during restart host ......................................................................
Patch Set 1: (1 inline comment) Looks good. Minor typo at commit msg. Worth checking if we have this anti pattern (rollback + non transactive ) in other places . .................................................... Commit Message Line 6: Line 7: engine: Fixing update of host status during restart host Line 8: Line 9: If we failed during restart a host status should be switched to NonResponsive, Line 10: the status was switched at roollback() nethod, but because of command is NonTransactive s/roolback/rollback Line 11: a rollback will be never called, so moving an update of status to execute Line 12: Line 13: Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c -- To view, visit http://gerrit.ovirt.org/13895 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d44a3ee76e2dc2490f8cf937a768c80826af46c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
