Mike Kolesnik has posted comments on this change. Change subject: core: Add providedBy field to Network ......................................................................
Patch Set 15: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java Line 57: private NetworkCluster cluster; Line 58: Line 59: private boolean vmNetwork = true; Line 60: Line 61: private ProviderNetwork providedBy; Actually it makes sense since the network is "provided by" a "provider", so the name does fit better than just calling the field "provider" which doesn't reflect the relationship direction. The same as I wouldn't call the "name" field "string" just because it's of type "String" Line 62: Line 63: @MTU Line 64: private int mtu; Line 65: -- To view, visit http://gerrit.ovirt.org/10784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bab3b703ab9982956c25cc5deec91abda93afd7 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
