Ori Liel has posted comments on this change.
Change subject: restapi: #920483 - Group Wrongly Displayed as User (within
permission)
......................................................................
Patch Set 1: (1 inline comment)
Answered your question about the tests - same answer applies to all places in
the tests where you asked this question
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEntityAssignedPermissionsResourceTest.java
Line 86: GetDbUserByUserIdParameters.class,
Line 87: new String[] { "UserId" },
Line 88: new Object[] { GUIDS[1] },
Line 89: getUserByIdx(1),
Line 90: 3);
It's because of this change:
In BackendAssignedPermissionsResource -->
public Permission map(permissions entity, DbUser user)
Replaced:
if (entity.getad_element_id() != null && user != null) {
With the more lenient:
if (entity.getad_element_id() != null)
Now the flow continues for the case of a group (when user==null), as it should,
and therefore GetDbUserByUserId is called in the test more times.
Line 91: setUpQueryExpectations("");
Line 92:
Line 93: collection.setUriInfo(uriInfo);
Line 94: verifyCollection(getCollection());
--
To view, visit http://gerrit.ovirt.org/13123
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08ad600d9b8af6dc8628a8ea9677d9c37fe89928
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
