Alon Bar-Lev has posted comments on this change.
Change subject: pki: update POSIX sh compatibility
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File backend/manager/conf/ca/CreateCA.sh
Line 3: die() {
Line 4: local m="$1"
Line 5: echo "$m" >&2
Line 6: exit 1
Line 7: }
Realy? will remove
Line 8:
Line 9: usage() {
Line 10: cat << __EOF__
Line 11: CreateCA.sh - Creates Certificate Authority certificate and keys
Line 46: openssl ca -selfsign -out ca.pem -in requests/ca.csr \
Line 47: -keyfile private/ca.pem -days 3650 -startdate "$4" \
Line 48: -config openssl.conf -extfile cacert.conf \
Line 49: -extensions v3_ca -batch && \
Line 50: openssl x509 -in ca.pem -out certs/ca.der
Done
Line 48
Line 49
Line 50
Line 51
Line 52
exit $? is useless, as the script will exit with $? anyway.
--
To view, visit http://gerrit.ovirt.org/13901
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ae7b6a9d88b87d134676acbd216a075bbad76f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
