Alon Bar-Lev has posted comments on this change.
Change subject: packaging: refactored firewalld support
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File packaging/fedora/setup/plugins/all_in_one_100.py
Line 228: '#migration',
Line 229: '-A INPUT -p tcp -m state --state NEW -m multiport --dports
49152:49216 -j ACCEPT'
Line 230: ]
Line 231:
Line 232: if basedefs.CONST_CONFIG_EXTRA_FIREWALLD_RULES not in
controller.CONF:
global, like #data center types enum ?
Line 233: controller.CONF[basedefs.CONST_CONFIG_EXTRA_FIREWALLD_RULES]
= []
Line 234:
controller.CONF[basedefs.CONST_CONFIG_EXTRA_FIREWALLD_RULES].append('ovirt-aio')
Line 235:
Line 236: def waitForJbossUp():
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 604: # Firewalld configuration
Line 605: %dir %{engine_data}/firewalld
Line 606: %{engine_data}/firewalld/ovirt-nfs.xml
Line 607: %{engine_data}/firewalld/ovirt-http.xml.in
Line 608: %{engine_data}/firewalld/ovirt-https.xml.in
well, you can always say dir/service and be that relative to some base, I
already see someone adds a service and forget to sync up.
Please remember that we need to package this as spec, ebuild and deb... we
should start making it easier for packager... even if it is somewhat more
complex for us in code.
Line 609:
Line 610: # Man pages
Line 611: %{_mandir}/man8/engine-setup.*
Line 612: %{_mandir}/man8/engine-upgrade.*
--
To view, visit http://gerrit.ovirt.org/13638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6a60e1667182f926f399e22bbfbb939e7171cb0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
