Allon Mureinik has posted comments on this change.

Change subject: engine: hashcode method simplification [wip]
......................................................................


Patch Set 3:

I don't understand why this patch was abandoned.

There are three engine-core reviewers assigned to this patch (and a couple of 
reviewers who aren't core maintainers, but let's leave that aside for a second).

One of them (your truly) gave +1 - This seems like an approach change, and I 
don't want to single handedly ack it.
The other two maintainers should either ack it, or explain why they think it's 
a bad idea.

--
To view, visit http://gerrit.ovirt.org/13385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad4e8f2e57728b97f0f72aa87c199b00fa242f6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to