Dan Kenigsberg has posted comments on this change.

Change subject: engine: send nic parameter in vmUpdateDevice [wip]
......................................................................


Patch Set 1: I would prefer that you didn't submit this

I do not see why this argument is needed (or what is its value in this 
context). Generally, if vdsm has a bug, it should be changed THERE, and not by 
changing the Engine/Vdsm API.

--
To view, visit http://gerrit.ovirt.org/13920
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I675ac79ab219a41db3533955a87105fa28370d75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to