Oved Ourfali has posted comments on this change. Change subject: core: unify GetImagesList using ImageFileType.All ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) 1. minor comment that you can ignore. 2. Have Daniel review the UI part, although it looked okay to me./ .................................................... File backend/manager/dbscripts/repo_files_meta_data_sp.sql Line 29: WHERE repo_domain_id = v_storage_domain_id; Line 30: ELSE Line 31: DELETE FROM repo_file_meta_data Line 32: WHERE repo_domain_id = v_storage_domain_id Line 33: AND file_type = v_file_type; consider using one delete here, using OR in the where clause. I guess it won't have much performance effect. Same below in the "get" function. Line 34: END IF; Line 35: Line 36: RETURN; Line 37: END; $procedure$ -- To view, visit http://gerrit.ovirt.org/13867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e8fb85c3f0d58778b03fd0aa101d95bbeebf3f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
