Alon Bar-Lev has posted comments on this change.
Change subject: sos - refactored engine sos plugin
......................................................................
Patch Set 3: (2 inline comments)
I know nothing about sos... but thank you for the cleanup, much better than the
strange workarounds.
....................................................
File src/__main__.py
Line 802: and all hypervisors.
Line 803: """
Line 804: print _('Creating compressed archive...')
Line 805: report_file_ext = 'bz2'
Line 806: compressor = '/usr/bin/bzip2'
avoid using full path
Line 807: if os.path.isfile('/usr/bin/xz'):
Line 808: report_file_ext = 'xz'
Line 809: compressor = '/usr/bin/xz'
Line 810:
Line 822: 'compressor': compressor,
Line 823: 'directory': self.conf["local_tmp_dir"],
Line 824: }
Line 825: caller = Caller(config)
Line 826: caller.call('/bin/tar -cf %(report)s -C %(directory)s .')
use tuple for arguments?
avoid use full path
Line 827: shutil.rmtree(self.conf["local_tmp_dir"])
Line 828: caller.call('%(compressor)s -1 %(report)s')
Line 829: md5_out = caller.call('/bin/md5sum %(compressed_report)s')
Line 830: checksum = md5_out.split()[0]
--
To view, visit http://gerrit.ovirt.org/13939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib226ec23b98450a03ebd2a64043a911645a62235
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
