Gilad Chaplik has posted comments on this change.
Change subject: webadmin: enhance warning dialog on host restart
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 1258: }
Line 1259:
Line 1260: public void Restart()
Line 1261: {
Line 1262: Constants constants =
ConstantsManager.getInstance().getConstants();
declare as final static or remove declaration.
Line 1263: ConfirmationModel model = new ConfirmationModel();
Line 1264: setConfirmWindow(model);
Line 1265: model.setTitle(constants.restartHostsTitle());
Line 1266: model.setHashName("restart_host"); //$NON-NLS-1$
Line 1265: model.setTitle(constants.restartHostsTitle());
Line 1266: model.setHashName("restart_host"); //$NON-NLS-1$
Line 1267:
model.setMessage(constants.areYouSureYouWantToRestartTheFollowingHostsMsg());
Line 1268: ArrayList<String> items = new ArrayList<String>();
Line 1269: String vdsEntry = "%1$s (%2$d " + constants.runningVms() +
")"; //$NON-NLS-1$ //$NON-NLS-2$
consider putting this entry in messages.java
Line 1270: for (Object item : getSelectedItems())
Line 1271: {
Line 1272: VDS vds = (VDS) item;
Line 1273: int runningVms = vds.getVmCount();
--
To view, visit http://gerrit.ovirt.org/13801
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If1c09b529d445ce4e6c3131d227ceffb22cd292d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
