Omer Frenkel has posted comments on this change.
Change subject: gluster: Refactor GetGlusterServersForImportQuery
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
Line 29: }
Line 30:
Line 31: @Override
Line 32: protected void executeQueryCommand() {
Line 33: getQueryReturnValue().setSucceeded(true);
why setting this to true anyway, even if exceptions are thrown?
Line 34:
Line 35: // Check whether the given server is already part of the
cluster
Line 36: if
(getVdsStaticDao().getByHostName(getParameters().getServerName()) != null
Line 37: ||
getVdsStaticDao().getAllWithIpAddress(getParameters().getServerName()).size() >
0) {
--
To view, visit http://gerrit.ovirt.org/13977
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4620c19997c10b202ef5dc5abdbeee9f245937d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
