Mike Kolesnik has posted comments on this change.
Change subject: engine: remove dual mode from VmInterfaceType (wip)
......................................................................
Patch Set 2: (3 inline comments)
How about adding support for old OVF that stiff has this value?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 116: // interfaces) + (all disks that are not IDE)
Line 117: int pciInUse = monitorsNumber;
Line 118:
Line 119: for (VmNetworkInterface a : interfaces) {
Line 120: pciInUse += 1;
How about instead do
pciInUse += interfaces.size();
?
Line 121: }
Line 122:
Line 123: pciInUse += LinqUtils.filter(disks, new Predicate<T>() {
Line 124: @Override
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 309:
Line 310: if (vmInterface.getType() != null) {
Line 311: ifaceType =
VmInterfaceType.forValue(vmInterface.getType());
Line 312: }
Line 313: addNetworkInterfaceProperties(struct,
Indentation should probably be fixed here
Line 314: vmInterface,
Line 315: vmDevice,
Line 316: ifaceType.toString(),
Line 317: vm.getVdsGroupCompatibilityVersion());
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java
Line 151: ifaceType =
VmInterfaceType.forValue(vm.getInterfaces().get(i)
Line 152: .getType());
Line 153: }
Line 154:
Line 155: nics.append(ifaceType.toString());
Indentation should probably be fixed here
Line 156:
Line 157: if (i < vm.getInterfaces().size() - 1) {
Line 158: macs.append(",");
Line 159: nics.append(",");
--
To view, visit http://gerrit.ovirt.org/13008
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17174d169160e535a383ba8ea1c99bc6f1d0cc3f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
