Yair Zaslavsky has posted comments on this change.
Change subject: core: move findActiveISODomain to IsoDomainListSyncronizer (2)
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java
Line 96: * @return Singleton instance of IsoDomainManager
Line 97: */
Line 98: public static IsoDomainListSyncronizer getInstance() {
Line 99: if (isoDomainListSyncronizer == null) {
Line 100: synchronized (IsoDomainListSyncronizer.class) {
Can you elaborate on the motivation to change the getInstance?
Why not have static initialization?
Line 101: if (isoDomainListSyncronizer == null) {
Line 102: isoDomainListSyncronizer = new
IsoDomainListSyncronizer();
Line 103: }
Line 104: }
Line 774: }
Line 775: return isoGuid;
Line 776: }
Line 777:
Line 778: private StorageDomainDAO getStorageDomainDAO() {
s/private/protected (if we ever want to add a test to IsoDomainListSynchronizer
and mock the DAO, this is a good start).
Line 779: return DbFacade.getInstance().getStorageDomainDao();
Line 780: }
--
To view, visit http://gerrit.ovirt.org/13398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icce0924f3b7875752b4ff1df7b55d9e293da5cd6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
