Yair Zaslavsky has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction clean-up (7)
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 282: private static DiskDao getDiskDao() {
Line 283: return DbFacade.getInstance().getDiskDao();
Line 284: }
Line 285:
Line 286: private static storage_pool fetchStoragePool(Guid storagePoolId) {
Once again, for the sake of future mocking - why static and why private?
Line 287: return
DbFacade.getInstance().getStoragePoolDao().get(storagePoolId);
Line 288: }
Line 289:
Line 290: private static RunVmValidator getRunVmValidator() {
--
To view, visit http://gerrit.ovirt.org/13660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37e73f99f15b69b9e41527a1ae8de66d80c36a17
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
