Yair Zaslavsky has posted comments on this change.
Change subject: core: removing canRunVm helper compat method
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 322: if (!result.isValid()) {
Line 323: messages.add(result.getMessage().toString());
Line 324: return false;
Line 325: }
Line 326: return true;
I would split to smaller methods.
Line 327: }
Line 328:
Line 329: private static SnapshotsValidator getSnapshotValidator() {
Line 330: return snapshotValidator;
--
To view, visit http://gerrit.ovirt.org/13696
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5063a8ae840ee27736722015480748ece048337
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
