Allon Mureinik has posted comments on this change.
Change subject: core: WIP: Add support for backup/restore API for ISVs
......................................................................
Patch Set 2: (4 inline comments)
Sharad - please see comments inline.
However, I must say that I don't quite get where this is going yet, so it's
pretty hard to say anything intelligent about it.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Backup.java
Line 3: import java.util.Date;
Line 4:
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public class Backup extends IVdcQueryable implements
BusinessEntity<Guid> {
Since this is VM-centric, consider renaming it to VM-backup
Line 8:
Line 9: /**
Line 10: * Needed for java serialization/deserialization mechanism.
Line 11: */
Line 105: this.vmId = vmId;
Line 106: }
Line 107:
Line 108: public String getVmConfig() {
Line 109: return vmConfig;
Why do we need this member?
Isn't it deducible from the VM id?
Line 110: }
Line 111:
Line 112: public void setVmConfig(String vmConfig) {
Line 113: this.vmConfig = vmConfig;
Line 130:
Line 131: public enum BackupType {
Line 132: FULL,
Line 133: DIFFERENTIAL,
Line 134: INCREMENTAl
what's the difference between DIFFERENTIAL and INCREMENTAl ?
Also, nit-picking - the last l in INCREMENTAl should also be capital
Line 135: }
Line 136:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PrepareDiskForBackupVDSCommand.java
Line 1: package org.ovirt.engine.core.vdsbroker.vdsbroker;
Line 2:
Line 3: import
org.ovirt.engine.core.common.vdscommands.archive.PrepareDiskForBackupVDSCommandParameters;
Line 4:
Line 5: public class PrepareDiskForBackupVDSCommand<P extends
PrepareDiskForBackupVDSCommandParameters> extends VdsBrokerCommand<P> {
should this really be done per disk and not per VM?
Line 6:
Line 7: public PrepareDiskForBackupVDSCommand(P parameters) {
Line 8: super(parameters);
Line 9: }
--
To view, visit http://gerrit.ovirt.org/13279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f48e96856acc47bc748aed777f11c6ebee3f140
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
