Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing XmlRpcStruct
......................................................................
Patch Set 1: (1 inline comment)
Overall, looks good.
I would consider getting rid of all xmlRpcStruct as variable names.
Also - up to you, in most cases you used map with the generic form, there are
only few cases were you didn't.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImageInfoVDSCommand.java
Line 75:
Line 76: /**
Line 77: * <exception>VdcDAL.IrsBrokerIRSErrorException.
Line 78: */
Line 79: public DiskImage buildImageEntity(Map<String, Object>
xmlRpcStruct) {
if you clean , clean all the way :)
s/xmlRpcStruct/map
Line 80: DiskImage newImage = new DiskImage();
Line 81: try {
Line 82: newImage.setImageId(new Guid((String)
xmlRpcStruct.get(IrsProperties.uuid)));
Line 83:
--
To view, visit http://gerrit.ovirt.org/14032
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f5de61b8b0ea31f6fd16beb02d37b524f39879
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
