Oved Ourfali has posted comments on this change.
Change subject: findbugs: Method fail to close stream
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 112: String schemaNamePostfix = job + number;
Line 113: InputStream is =
BaseDAOTestCase.class.getResourceAsStream(
Line 114: "/test-database.properties");
Line 115: properties.load(is);
Line 116: is.close();
Shouldn't it be done in the finally block?
Line 117: ClassLoader.getSystemClassLoader().loadClass(
Line 118: properties.getProperty("database.driver"));
Line 119: String dbUrl = properties.getProperty("database.url") +
schemaNamePostfix;
Line 120: result = new SingleConnectionDataSource(
--
To view, visit http://gerrit.ovirt.org/14037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bea678c1aaeeb6dfe92b16e380e4bc631e3d09c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
