Omer Frenkel has posted comments on this change. Change subject: core: prevent create snapshot when the vm has illegal disks. ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java Line 306: && validate(vmValidator.vmNotDuringMigration()) Line 307: && validate(vmValidator.vmNotRunningStateless()) Line 308: && validate(vmValidator.vmNotIlegal()) Line 309: && ImagesHandler.checkImagesIllegal(getReturnValue().getCanDoActionMessages(), disksList) Line 310: && ImagesHandler.PerformImagesChecks( ImagesHandler.PerformImagesChecks gets as parameter isValid=true which in his turn runs checkImagesLegalityInVdsm, that check the image status in vdsm, using GetImageInfo verb what is the difference, are these statuses sync'd between engine and the storage? Line 311: getReturnValue().getCanDoActionMessages(), Line 312: getVm().getStoragePoolId(), Line 313: Guid.Empty, Line 314: true, -- To view, visit http://gerrit.ovirt.org/13898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e6646fd2ead82c91f6660bc95c32ecaf046e266 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
