Maor Lipchuk has posted comments on this change.
Change subject: core: Extract SD validations from ImagesHandler
......................................................................
Patch Set 10: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java
Line 76: public void testAllDomainsExistAndActiveOneInactive() {
Line 77: domain1.setStatus(StorageDomainStatus.Active);
Line 78: domain2.setStatus(StorageDomainStatus.InActive);
Line 79: ValidationResult result = validator.allDomainsExistAndActive();
Line 80: assertFalse("Both domains should not be active",
result.isValid());
Perhaps consider to change the message so it will indicate, only one domain
should not be active (instead Both domains)
Line 81: assertEquals("Wrong validation error",
Line 82:
VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_STATUS_ILLEGAL,
Line 83: result.getMessage());
Line 84: }
Line 94: public void testAllDomainsWithinThresholdsOneLacking() {
Line 95: domain1.getStorageDynamicData().setAvailableDiskSize(15);
Line 96: domain2.getStorageDynamicData().setAvailableDiskSize(7);
Line 97: ValidationResult result =
validator.allDomainsWithinThresholds();
Line 98: assertFalse("Both domains should not be withing thresholds",
result.isValid());
Perhaps consider to change the message so it will indicate that domain2 has not
enough available disk size to pass the threshold check.
Line 99: assertEquals("Wrong validation error",
Line 100:
VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_TARGET_STORAGE_DOMAIN,
Line 101: result.getMessage());
Line 102: }
--
To view, visit http://gerrit.ovirt.org/12249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
