Sahina Bose has posted comments on this change.

Change subject: core,webadmin: Host reboot false for gluster only host
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 249:     private Integer spmMaxPriorityValue;
Line 250:     private Integer spmDefaultPriorityValue;
Line 251:     private int spmLowPriorityValue;
Line 252:     private int spmHighPriorityValue;
Line 253:     private final int spmNeverPriorityValue = -1;
This was added by default due to eclipse settings. Will remove.
Line 254: 
Line 255:     public Integer getSpmPriorityValue() {
Line 256:         return spmPriorityValue;
Line 257:     }


Line 891:     }
Line 892: 
Line 893:     public void OnInstall()
Line 894:     {
Line 895:         InstallModel model = (InstallModel) getWindow();
Done
Line 896:         boolean isOVirt = getEntity().getVdsType() == 
VDSType.oVirtNode;
Line 897: 
Line 898:         if (!model.Validate(isOVirt))
Line 899:         {


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
Line 828: 
Line 829:         CancelConfirm();
Line 830:         model.StartProgress(null);
Line 831: 
Line 832:         boolean isVirt = ((VDSGroup) 
model.getCluster().getSelectedItem()).supportsVirtService();
Done
Line 833: 
Line 834:         if (model.getIsNew())
Line 835:         {
Line 836:             AddVdsActionParameters parameters = new 
AddVdsActionParameters();


--
To view, visit http://gerrit.ovirt.org/13384
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c52e32de914b21998fa334088b302ec70aef49f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to