Daniel Erez has posted comments on this change. Change subject: userportal,webadmin: implement VM builder ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/CommonUnitToVmBuilder.java Line 24: backend.setNumOfMonitors((Integer) frontend.getNumOfMonitors().getSelectedItem()); Line 25: backend.setAllowConsoleReconnect((Boolean) frontend.getAllowConsoleReconnect().getEntity()); Line 26: backend.setVmMemSizeMb((Integer) frontend.getMemSize().getEntity()); Line 27: backend.setMinAllocatedMem((Integer) frontend.getMinAllocatedMemory().getEntity()); Line 28: backend.setTimeZone((frontend.getTimeZone().getIsAvailable() && frontend.getTimeZone().getSelectedItem() != null) ? ((Map.Entry<String, String>) frontend.getTimeZone() please format this section (too long lines...) Line 29: .getSelectedItem()).getKey() Line 30: : ""); //$NON-NLS-1$ Line 31: backend.setNumOfSockets((Integer) frontend.getNumOfSockets().getSelectedItem()); Line 32: backend.setCpuPerSocket(Integer.parseInt(frontend.getTotalCPUCores().getEntity().toString()) -- To view, visit http://gerrit.ovirt.org/13915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54d938896e469c73800297c3d66185a439243a41 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
