Libor Spevak has posted comments on this change.

Change subject: core,webadmin: Show Pools tab based on tree
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/dbscripts/create_views.sql
Line 777:       LEFT JOIN vm_pool_map vm_pool_map_1 ON v2.vm_pool_id = 
vm_pool_map_1.vm_pool_id AND v2.vm_pool_id = vmp.vm_pool_id
Line 778:    LEFT JOIN vm_dynamic ON vm_pool_map_1.vm_guid = vm_dynamic.vm_guid 
 
Line 779:   WHERE vm_dynamic.status <> ALL (ARRAY[0, 15])
Line 780:   GROUP BY v2.vm_pool_id) AS vm_running_count, vmp.storage_pool_name, 
vmp.storage_pool_id
Line 781:    FROM vm_pools_view vmp;
Yes, you are right, I used it as PGADMIN formatted it, which is much better 
than original version done by hand.

This was added:
storage_pool.name as storage_pool_name, storage_pool.id as storage_pool_id
....
JOIN storage_pool ON storage_pool.id = vds_groups.storage_pool_id;
...
vmp.storage_pool_name, vmp.storage_pool_id
Line 782: 
Line 783: 
Line 784: 
Line 785: CREATE OR REPLACE VIEW permissions_view


--
To view, visit http://gerrit.ovirt.org/14073
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39c39366865ff6a62d30fab993685c72e0c39e10
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Libor Spevak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to