Alona Kaplan has posted comments on this change.
Change subject: webadmin: Color Setup Networks label when operation invalid
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 193:
Line 194: NetworkOperation candidate =
NetworkOperationFactory.operationFor(op1, op2, true);
Line 195:
Line 196: if (drop) {
Line 197: if (candidate.isNullOperation()) {
I think this code should reside in onOperation.
Line 198: getNullOperationEvent().raise(this, null);
Line 199: }
Line 200: onOperation(candidate, candidate.getCommand(op1, op2,
allNics));
Line 201: } else {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
Line 146: OperationCadidateEventArgs evtArgs =
(OperationCadidateEventArgs) args;
Line 147: NetworkOperation candidate = evtArgs.getCandidate();
Line 148: NetworkItemModel<?> op1 = evtArgs.getOp1();
Line 149: NetworkItemModel<?> op2 = evtArgs.getOp2();
Line 150: status.setFadeText(candidate != null ?
candidate.getMessage(op1, op2) : constants.noValidActionSetupNetwork());
Why do you need the null operation event? Why don't you add here-
if (candidate.isNullOperation()){
setStatusStyle(false);
}
Line 151: setStatusStyle(true);
Line 152: }
Line 153: });
Line 154:
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml
Line 154: .errorPanel{
Line 155: background-color: pink;
Line 156: height: 30px;
Line 157: border-bottom: 1px solid #C5C5C5;
Line 158: }
Please remove trailing white-space.
Line 159:
Line 160: .checkBoxesPanel{
Line 161: border-top: 1px solid #C5C5C5;
Line 162: width: 100%;
--
To view, visit http://gerrit.ovirt.org/14038
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbc6a77c1111dbad0c89a3c7f38b537eb1673c3e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
