Daniel Erez has uploaded a new change for review. Change subject: core: use DiskImage.copyOf in getAllDisks query ......................................................................
core: use DiskImage.copyOf in getAllDisks query GetAllDisksByStorageDomainIdQuery: add a copy of the active DiskImage to snapshots list [adding it as is causes infinte recursion in DiskImage->hashCode()] Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Bug-Url: https://bugzilla.redhat.com/951909 Signed-off-by: Daniel Erez <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/14102/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java index 2fcd2ec..90ef0f8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java @@ -25,7 +25,7 @@ // Get active diskImages for (DiskImage diskImage : diskImages) { if (diskImage.getActive()) { - diskImage.getSnapshots().add(diskImage); + diskImage.getSnapshots().add(DiskImage.copyOf(diskImage)); diskImagesMap.put(diskImage.getId(), diskImage); } } -- To view, visit http://gerrit.ovirt.org/14102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieef49f05980cdac8a5e3fbc3652a2ed261c6a8b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
