Doron Fediuck has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (3)
......................................................................
Patch Set 8: Looks good to me, but someone else must approve
(1 inline comment)
We can do better, but this will do for now.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 81:
message.add(vmDuringSnapshotResult.getMessage().name());
Line 82: retValue = false;
Line 83: }
Line 84: }
Line 85: List<DiskImage> vmImages =
ImagesHandler.filterImageDisks(vmDisks, true, false);
The above may not be needed if retValue = false;
So not urgent for now, but for next step(s) we can be more efficient.
Line 86: if (retValue && !vmImages.isEmpty()) {
Line 87: storage_pool sp =
getStoragePoolDAO().get(vm.getStoragePoolId());
Line 88: ValidationResult spUpResult = new
StoragePoolValidator(sp).isUp();
Line 89: if (!spUpResult.isValid()) {
--
To view, visit http://gerrit.ovirt.org/13399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida913a72e04c4edc57f9b6e2baf93e31e3df82f2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
