Shahar Havivi has uploaded a new change for review. Change subject: findbugs: Method invokes inefficient Number constructor ......................................................................
findbugs: Method invokes inefficient Number constructor Change-Id: Id868d7fe02fde3af616cef32328a3a893582f4e9 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java M backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 20 files changed, 41 insertions(+), 41 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/14128/1 diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java index e30a87a..5dd805e 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PostgresDataTypeFactory.java @@ -42,7 +42,7 @@ // Finally check whether the user defined a custom datatype if (isEnumType(sqlTypeName)) { logger.debugFormat("Custom enum type used for sqlTypeName {} (sqlType '{}')", - new Object[] { sqlTypeName, new Integer(sqlType) }); + new Object[] { sqlTypeName, Integer.valueOf(sqlType) }); return new GenericEnumType(sqlTypeName); } } diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java index c54da90..6e02195 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/QuotaDAOTest.java @@ -138,7 +138,7 @@ assertEquals(true, quotaVdsGroup.getVirtualCpuUsage() > 0); // Check if the global variable returns when null is initialization. - assertEquals(new Integer(100), quotaVdsGroup.getVirtualCpu()); + assertEquals(Integer.valueOf(100), quotaVdsGroup.getVirtualCpu()); } /** @@ -157,7 +157,7 @@ assertEquals(true, quotaVdsGroup.getMemSizeMBUsage() > 0); // Check if the global variable returns when null is initialization. - assertEquals(new Integer(100), quotaVdsGroup.getVirtualCpu()); + assertEquals(Integer.valueOf(100), quotaVdsGroup.getVirtualCpu()); } /** @@ -194,7 +194,7 @@ assertEquals(true, quotaVdsGroupList.size() == 1); // Check if the global variable returns when null is initialization. - assertEquals(quotaVdsGroup.getVirtualCpu(), new Integer(10)); + assertEquals(quotaVdsGroup.getVirtualCpu(), Integer.valueOf(10)); } /** diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java index ab83333..1846bbe 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmAndTemplatesGenerationsDaoTest.java @@ -72,7 +72,7 @@ @Test public void testGetVmTemplatesIdsForOvfUpdateOneTemplate() { - vmAndTemplatesGenerationsDAO.updateOvfGenerations(Collections.singletonList(FixturesTool.VM_TEMPLATE_RHEL5), Collections.singletonList(new Long(0))); + vmAndTemplatesGenerationsDAO.updateOvfGenerations(Collections.singletonList(FixturesTool.VM_TEMPLATE_RHEL5), Collections.singletonList(Long.valueOf(0))); List<Guid> guids = vmAndTemplatesGenerationsDAO.getVmTemplatesIdsForOvfUpdate(FixturesTool.STORAGE_POOL_RHEL6_ISCSI_OTHER); assertEquals("one template should need ovf update",1, guids.size()); @@ -134,7 +134,7 @@ @Test public void testGetVmssIdsForOvfUpdateOneVm() { - vmAndTemplatesGenerationsDAO.updateOvfGenerations(Collections.singletonList(FixturesTool.VM_RHEL5_POOL_50), Collections.singletonList(new Long(0))); + vmAndTemplatesGenerationsDAO.updateOvfGenerations(Collections.singletonList(FixturesTool.VM_RHEL5_POOL_50), Collections.singletonList(Long.valueOf(0))); List<Guid> guids = vmAndTemplatesGenerationsDAO.getVmsIdsForOvfUpdate(FixturesTool.STORAGE_POOL_RHEL6_ISCSI_OTHER); assertEquals("one vm should need ovf update",1, guids.size()); diff --git a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java index 73983b9..3a1bfed 100644 --- a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java +++ b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java @@ -406,7 +406,7 @@ model.setDomain(domain); } MemoryPolicy policy = new MemoryPolicy(); - policy.setGuaranteed(new Long(entity.getMinAllocatedMem() * BYTES_PER_MB)); + policy.setGuaranteed(Long.valueOf(entity.getMinAllocatedMem() * BYTES_PER_MB)); model.setMemoryPolicy(policy); model.setTimezone(TimeZoneMapping.getJava(entity.getTimeZone())); if (!StringUtils.isEmpty(entity.getCustomProperties())) { diff --git a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java index 72d9949..9e2b786 100644 --- a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java +++ b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/HostMapperTest.java @@ -62,9 +62,9 @@ vds.setCpuSpeedMh(5.5); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getCpu()); - assertEquals(new Integer(host.getCpu().getTopology().getCores()), new Integer(2)); - assertEquals(new Integer(host.getCpu().getTopology().getSockets()), new Integer(3)); - assertEquals(new Integer(host.getCpu().getTopology().getThreads()), new Integer(2)); + assertEquals(Integer.valueOf(host.getCpu().getTopology().getCores()), Integer.valueOf(2)); + assertEquals(Integer.valueOf(host.getCpu().getTopology().getSockets()), Integer.valueOf(3)); + assertEquals(Integer.valueOf(host.getCpu().getTopology().getThreads()), Integer.valueOf(2)); assertEquals(host.getCpu().getName(), "some cpu model"); assertEquals(host.getCpu().getSpeed(), new BigDecimal(5.5)); } @@ -77,9 +77,9 @@ vds.setVmActive(1); vds.setVmMigrating(1); Host host = HostMapper.map(vds, (Host) null); - assertEquals(host.getSummary().getTotal(), new Integer(2)); - assertEquals(host.getSummary().getActive(), new Integer(1)); - assertEquals(host.getSummary().getMigrating(), new Integer(1)); + assertEquals(host.getSummary().getTotal(), Integer.valueOf(2)); + assertEquals(host.getSummary().getActive(), Integer.valueOf(1)); + assertEquals(host.getSummary().getMigrating(), Integer.valueOf(1)); } @Test @@ -89,7 +89,7 @@ vds.setPhysicalMemMb(4000); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getMemory()); - assertEquals(new Long(host.getMemory()), new Long(4194304000L)); + assertEquals(Long.valueOf(host.getMemory()), Long.valueOf(4194304000L)); } @Test @@ -119,8 +119,8 @@ assertTrue(host.getOs().isSetVersion()); assertEquals(host.getOs().getType(), "Fedora"); assertEquals(host.getOs().getVersion().getFullVersion(), "17 - 1"); - assertEquals(new Long(host.getOs().getVersion().getMajor()), new Long(17)); - assertEquals(new Long(host.getOs().getVersion().getMinor()), new Long(1)); + assertEquals(Long.valueOf(host.getOs().getVersion().getMajor()), Long.valueOf(17)); + assertEquals(Long.valueOf(host.getOs().getVersion().getMinor()), Long.valueOf(1)); } @Test @@ -130,10 +130,10 @@ vds.setVersion(new RpmVersion("vdsm-4.10.0-10.fc17", "vdsm-", true)); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getVersion()); - assertEquals(new Long(host.getVersion().getMajor()), new Long(4)); - assertEquals(new Long(host.getVersion().getMinor()), new Long(10)); - assertEquals(new Long(host.getVersion().getRevision()), new Long(0)); - assertEquals(new Long(host.getVersion().getBuild()), new Long(0)); + assertEquals(Long.valueOf(host.getVersion().getMajor()), Long.valueOf(4)); + assertEquals(Long.valueOf(host.getVersion().getMinor()), Long.valueOf(10)); + assertEquals(Long.valueOf(host.getVersion().getRevision()), Long.valueOf(0)); + assertEquals(Long.valueOf(host.getVersion().getBuild()), Long.valueOf(0)); assertEquals(host.getVersion().getFullVersion(), "vdsm-4.10.0-10.fc17"); } @@ -189,10 +189,10 @@ vds.setLibvirtVersion(new RpmVersion("libvirt-0.9.10-21.el6_3.4", "libvirt-", true)); Host host = HostMapper.map(vds, (Host) null); assertNotNull(host.getLibvirtVersion()); - assertEquals(new Long(host.getLibvirtVersion().getMajor()), new Long(0)); - assertEquals(new Long(host.getLibvirtVersion().getMinor()), new Long(9)); - assertEquals(new Long(host.getLibvirtVersion().getRevision()), new Long(0)); - assertEquals(new Long(host.getLibvirtVersion().getBuild()), new Long(10)); + assertEquals(Long.valueOf(host.getLibvirtVersion().getMajor()), Long.valueOf(0)); + assertEquals(Long.valueOf(host.getLibvirtVersion().getMinor()), Long.valueOf(9)); + assertEquals(Long.valueOf(host.getLibvirtVersion().getRevision()), Long.valueOf(0)); + assertEquals(Long.valueOf(host.getLibvirtVersion().getBuild()), Long.valueOf(10)); assertEquals(host.getLibvirtVersion().getFullVersion(), "libvirt-0.9.10-21.el6_3.4"); } } diff --git a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java index 4ec8379..4e9a9f6 100644 --- a/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java +++ b/backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapperTest.java @@ -50,7 +50,7 @@ assertEquals(entity.getVendorId(), "vendor_id_1"); assertEquals(entity.getProductId(), "product_id_1"); assertEquals(entity.getSerial(), "some_serial"); - assertEquals(entity.getLunMapping(), new Integer(5)); + assertEquals(entity.getLunMapping(), Integer.valueOf(5)); assertEquals(entity.getVolumeGroupId(), "volume_group_id_1"); assertEquals(entity.getStorageDomainId(), Guid.Empty.toString()); assertEquals(entity.getDiskId(), Guid.Empty.toString()); diff --git a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java index d1e3014..b6a5004 100644 --- a/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java +++ b/backend/manager/modules/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java @@ -294,7 +294,7 @@ Object[] input = new Object[2]; input[0] = new String("msg1"); - input[1] = new Integer(5); + input[1] = Integer.valueOf(5); scheduler.scheduleAOneTimeJob(pj, "onTimerWithParam", inputType, input, 1, TimeUnit.MILLISECONDS); try { Thread.sleep(50); diff --git a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java index 9d857c4..d78c127 100644 --- a/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java +++ b/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReapedMapTest.java @@ -49,7 +49,7 @@ map.reapable("one"); assertSizes(1, 2); assertExpected(1, 2, 3); - assertEquals(new Integer(3), map.remove("three")); + assertEquals(Integer.valueOf(3), map.remove("three")); assertSizes(1, 1); assertExpected(1, 2); assertNull(map.get("three")); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java index 2393064..f43988a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateImageVDSCommand.java @@ -37,7 +37,7 @@ getParameters().getStorageDomainId().toString(), getParameters().getStoragePoolId().toString(), getParameters().getImageGroupId().toString(), - (new Long(getParameters().getImageSizeInBytes())).toString(), + (Long.valueOf(getParameters().getImageSizeInBytes())).toString(), getParameters().getVolumeFormat().getValue(), getParameters().getImageType().getValue(), 2, diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java index 0e81941..93756df 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/CreateSnapshotVDSCommand.java @@ -38,7 +38,7 @@ uuidReturn = getIrsProxy().createVolume(getParameters().getStorageDomainId().toString(), getParameters().getStoragePoolId().toString(), getParameters().getImageGroupId().toString(), - (new Long(getParameters().getImageSizeInBytes())).toString(), + (Long.valueOf(getParameters().getImageSizeInBytes())).toString(), getParameters().getVolumeFormat().getValue(), getParameters().getImageType().getValue(), 2, diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java index 28d944f..713786f 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java @@ -44,7 +44,7 @@ info.append(o); info.append(EQUAL); info.append(createInfo.get(o)); - sep = (new Character(SEP)).toString(); + sep = (Character.valueOf(SEP)).toString(); } log.infoFormat("{0} {1}", getClass().getName(), info.toString()); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java index c48c030..2959fa4 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DestroyVDSCommand.java @@ -13,7 +13,7 @@ protected void ExecuteVdsBrokerCommand() { if (getParameters().getGracefully()) { status = getBroker().shutdown(getParameters().getVmId().toString(), - (new Integer(getParameters().getSecondsToWait())).toString(), + (Integer.valueOf(getParameters().getSecondsToWait())).toString(), Config.<String> GetValue(ConfigValues.VmGracefulShutdownMessage)); } else { status = getBroker().destroy(getParameters().getVmId().toString()); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java index 6d8055a..5670290 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/EditNetworkVDSCommand.java @@ -57,7 +57,7 @@ if (getParameters().getCheckConnectivity()) { options.put(VdsProperties.CONNECTIVITY_CHECK, "true"); options.put(VdsProperties.CONNECTIVITY_TIMEOUT, - (new Integer(getParameters().getConnectionTimeout())).toString()); + (Integer.valueOf(getParameters().getConnectionTimeout())).toString()); } status = getBroker().editNetwork(oldNetwork, networkName, vlanId, bond, nics, options); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java index fc9239c..dcac69a 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java @@ -28,11 +28,11 @@ Map<String, String> params = new HashMap<String, String>(); params.put("userName", getParameters().getUserName()); params.put("userId", getParameters().getUserId().toString()); - status = getBroker().setVmTicket(mVmId.toString(), mTicket, (new Integer(mValidTime)).toString(), + status = getBroker().setVmTicket(mVmId.toString(), mTicket, (Integer.valueOf(mValidTime)).toString(), connectionAction, params); } else { - status = getBroker().setVmTicket(mVmId.toString(), mTicket, (new Integer(mValidTime)).toString()); + status = getBroker().setVmTicket(mVmId.toString(), mTicket, (Integer.valueOf(mValidTime)).toString()); } ProceedProxyReturnValue(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java index a99197c..fbb5069 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java @@ -440,7 +440,7 @@ } private static void addBootOrder(VmDevice vmDevice, Map<String, Object> struct) { - String s = new Integer(vmDevice.getBootOrder()).toString(); + String s = Integer.valueOf(vmDevice.getBootOrder()).toString(); if (!org.apache.commons.lang.StringUtils.isEmpty(s) && !s.equals("0")) { struct.put(VdsProperties.BootOrder, s); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java index c943391..c06bb40 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java @@ -45,7 +45,7 @@ createInfo.put(VdsProperties.mem_size_mb, vm.getVmMemSizeMb()); createInfo.put(VdsProperties.smartcardEnabled, Boolean.toString(vm.isSmartcardEnabled())); createInfo.put(VdsProperties.num_of_cpus, - (new Integer(vm.getNumOfCpus())).toString()); + (Integer.valueOf(vm.getNumOfCpus())).toString()); if (Config.<Boolean> GetValue(ConfigValues.SendSMPOnRunVm)) { createInfo.put(VdsProperties.cores_per_socket, (Integer.toString(vm.getCpuPerSocket()))); @@ -82,7 +82,7 @@ vm.getVdsGroupCpuFlagsData()); } createInfo.put(VdsProperties.niceLevel, - (new Integer(vm.getNiceLevel())).toString()); + (Integer.valueOf(vm.getNiceLevel())).toString()); if (vm.getStatus() == VMStatus.Suspended && !StringUtils.isEmpty(vm.getHibernationVolHandle())) { createInfo.put(VdsProperties.hiberVolHandle, diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java index 3dcc95c..0a0276d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java @@ -63,7 +63,7 @@ long xid = x.getaudit_log_id(); long yid = y.getaudit_log_id(); - return (new Long(xid)).compareTo(yid); + return (Long.valueOf(xid)).compareTo(yid); } } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java index 23949c1..d6e94d0 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java @@ -790,7 +790,7 @@ } if (i > 0) { - commonName = getCommonName() + (new Integer(i)).toString(); + commonName = getCommonName() + (Integer.valueOf(i)).toString(); } return commonName; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java index c61025f..4eb9e46 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java @@ -1751,7 +1751,7 @@ ArrayList<BootSequence> items = new ArrayList<BootSequence>(); for (char a : value.toString().toCharArray()) { - items.add(BootSequence.valueOf((new Character(a)).toString())); + items.add(BootSequence.valueOf((Character.valueOf(a)).toString())); } Object firstBootDevice = null; diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java index 39975aa..4769ad9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java @@ -359,7 +359,7 @@ { int val1 = (Integer) item.getEntity(); int val2 = (Integer) oldPriority.getEntity(); - if ((new Integer(val1)).equals(val2)) + if ((Integer.valueOf(val1)).equals(val2)) { getModel().getPriority().setSelectedItem(item); break; -- To view, visit http://gerrit.ovirt.org/14128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id868d7fe02fde3af616cef32328a3a893582f4e9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
