Alon Bar-Lev has posted comments on this change. Change subject: Renamed engine-iso-uploader in ovirt-iso-uploader ......................................................................
Patch Set 2: (1 inline comment) I think that man page link should be provided... .................................................... File src/Makefile.am Line 56: chmod a+x "$(DESTDIR)$(ovirtisouploaderlibdir)/__main__.py" Line 57: rm -f "$(DESTDIR)$(bindir)/ovirt-iso-uploader" Line 58: rm -f "$(DESTDIR)$(bindir)/engine-iso-uploader" Line 59: $(LN_S) "$(ovirtisouploaderlibdir)/__main__.py" "$(DESTDIR)$(bindir)/ovirt-iso-uploader" Line 60: $(LN_S) "$(ovirtisouploaderlibdir)/__main__.py" "$(DESTDIR)$(bindir)/engine-iso-uploader" I would have linked engine-iso-uploader->ovirt-iso-uploader Line 61: Line 62: uninstall-hook: Line 63: rm -f "$(DESTDIR)$(bindir)/ovirt-iso-uploader" -- To view, visit http://gerrit.ovirt.org/14133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f6cc47a3e068a62d6e8bdcd20f360e1d2a53c1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
