Yair Zaslavsky has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
Line 67: LdapCredentials ldapCredentials = new
LdapCredentials(loginNameForKerberos, getPassword());
Line 68: DirectorySearcher directorySearcher = new
DirectorySearcher(ldapCredentials);
Line 69: executeQuery(directorySearcher);
Line 70: } catch (RuntimeException e) {
Line 71: String msg = String.format("Failed to run command %s.
Domain is %s. User is %s.",
Gilad, I do not see that in any other place in the engine code we use
Frontend.getAppErrorsTranslator, and it feels not in place.
Is there a way we do the translation at frontend side, same way it's done in
ClusterListModel for example?
Line 72: getClass().getSimpleName(), getDomain(),
getLoginName());
Line 73: log.errorFormat(msg);
Line 74: _ldapReturnValue.setExceptionString(msg);
Line 75: }
--
To view, visit http://gerrit.ovirt.org/11893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
