Shireesh Anjal has posted comments on this change. Change subject: engine: VDS command to get gluster host UUID ......................................................................
Patch Set 4: Looks good to me, approved (1 inline comment) Fix the vdsm error code, and we are good to go. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java Line 372: GlusterHookDisableFailed(4502), Line 373: GlusterHookAlreadyEnabled(4503), Line 374: GlusterHookAlreadyDisabled(4504), Line 375: GlusterHookNotFound(4505), Line 376: GlusterHostUUIDNotFound(4520), Change to 4408 as per http://gerrit.ovirt.org/#/c/13785/3/vdsm/gluster/exception.py Line 377: Line 378: UnicodeArgumentException(4900), Line 379: Line 380: // oVirt errors -- To view, visit http://gerrit.ovirt.org/13941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie73558f8c9469e1ce3710e4d77fa1072059267ad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
