Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Added generic DB validations before the upgrade
......................................................................
Patch Set 12: (3 inline comments)
Thanks!!!!
Almost there... I think you agree that this is much simpler than what we had...
....................................................
File backend/manager/tools/dbutils/validatedb.sh
Line 1: #!/bin/sh
I thought you will choose tabs... :)))
Line 2:
Line 3: #include db general functions
Line 4: dbutils=$(dirname ${0})
Line 5:
Line 58: done
Line 59:
Line 60: validationlist="fkvalidator.sh"
Line 61:
Line 62: echo " ====== Validating database '${dbname}' ====== "
This should be printed by the setup code, it will look different in each setup
(legacy and new).
Line 63:
Line 64: for script in ${validationlist}; do
Line 65: $dbutils/${script} ${USERNAME} ${SERVERNAME} ${PORT}
${DATABASE} -q ${extra_params} || error=1
Line 66: done
Line 64: for script in ${validationlist}; do
Line 65: $dbutils/${script} ${USERNAME} ${SERVERNAME} ${PORT}
${DATABASE} -q ${extra_params} || error=1
Line 66: done
Line 67: exit ${error}
Line 68:
No need for extra line...
--
To view, visit http://gerrit.ovirt.org/12512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
