Roy Golan has posted comments on this change.
Change subject: core: [cleanup] split execute method of CreateAllSnapshots
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 108: addSnapshotToDB(createdSnapshotId);
Line 109: createSnapshotsForDisks(getDisksList(), newActiveSnapshotId);
Line 110:
Line 111: if (getTaskIdList().isEmpty()) {
Line 112: getParameters().setTaskGroupSuccess(true);
this is being called on a different flow now. is this intentional?
Line 113: incrementVmGeneration();
Line 114: }
Line 115: setSucceeded(true);
Line 116: }
--
To view, visit http://gerrit.ovirt.org/14179
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie401b3aa60abba497237e02c77d8d3a77cef9a20
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
