Allon Mureinik has uploaded a new change for review. Change subject: core: Fix redundant space in DB upgrade output ......................................................................
core: Fix redundant space in DB upgrade output The run_file function only receives one argument, so $2 is always evaluated as an empty string. This cause the database upgrade/creation scripts to print "Running upgrade sql script" and "Running upgrade shell script", with two whitespaces after "Running" instead of just one. Removing the call to $2 resolves this issue. Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/95/14195/1 diff --git a/backend/manager/dbscripts/dbfunctions.sh b/backend/manager/dbscripts/dbfunctions.sh index 73e15d3..d78ad3a 100755 --- a/backend/manager/dbscripts/dbfunctions.sh +++ b/backend/manager/dbscripts/dbfunctions.sh @@ -216,11 +216,11 @@ local execFile=${1} isShellScript=$(file $execFile | grep "shell" | wc -l) if [ $isShellScript -gt 0 ]; then - echo "Running $2 upgrade shell script $execFile ..." + echo "Running upgrade shell script $execFile ..." export DATABASE="${DATABASE}" SERVERNAME="${SERVERNAME}" PORT="${PORT}" USERNAME="${USERNAME}" ./$execFile else - echo "Running $2 upgrade sql script $execFile ..." + echo "Running upgrade sql script $execFile ..." execute_file $execFile ${DATABASE} ${SERVERNAME} ${PORT} > /dev/null fi } -- To view, visit http://gerrit.ovirt.org/14195 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3cb5f8778e570df1f2f76f3a16d32530b9a24b52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
