Omer Frenkel has posted comments on this change.
Change subject: core: [cleanup] organize canMigrateVm method
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
Line 225: protected boolean canMigrateVm(VM vm) {
Line 226: if (vm == null) {
Line 227: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND);
Line 228: }
Line 229: else {
else is not needed if you return
Line 230: // If VM is pinned to host, no migration can occur
Line 231: if (vm.getMigrationSupport() ==
MigrationSupport.PINNED_TO_HOST) {
Line 232: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_PINNED_TO_HOST);
Line 233: }
--
To view, visit http://gerrit.ovirt.org/14125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica36ecc272a295ee82ec51d7b62a90d84489d8c9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
