Michael Kublin has posted comments on this change.
Change subject: core: initVdsOnUp - remove reconstruct and host status.
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 183: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 184: vds.getVdsSpmId(), masterDomain.getId(),
Line 185:
storagePool.getmaster_domain_version())).getSucceeded();
Line 186: } catch (VdcBLLException e) {
Line 187: boolean isMasterDomainInactiveOrUnknown =
(masterDomain.getStatus() == StorageDomainStatus.InActive
No boolean needed there, it used only once, bad code styling
Line 188: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown);
Line 189: if (e.getErrorCode() != VdcBllErrors.VDS_NETWORK_ERROR &&
isMasterDomainInactiveOrUnknown) {
Line 190: shouldProceedVdsStats = false;
Line 191: result.setSuccess(true);
Line 187: boolean isMasterDomainInactiveOrUnknown =
(masterDomain.getStatus() == StorageDomainStatus.InActive
Line 188: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown);
Line 189: if (e.getErrorCode() != VdcBllErrors.VDS_NETWORK_ERROR &&
isMasterDomainInactiveOrUnknown) {
Line 190: shouldProceedVdsStats = false;
Line 191: result.setSuccess(true);
Please explain meaning of line 191?
Line 192: } else {
Line 193: log.errorFormat("Could not connect host {0} to pool
{1}", vds.getName(), storagePool
Line 194: .getname());
Line 195: result.setSuccess(false);
--
To view, visit http://gerrit.ovirt.org/13709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6418b9d2826146e1e4ceff4341c6d7cd3a0024af
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
